couple of errors appeared

Started by lesmond, Jul 14, 2021, 05:29 AM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

lesmond

Not that I'm a coder, I added the commits to a new RC4 install, nothing has changed errors still there, and tried using GB,USA or is there something I'm not doing? :dontknow

The only person who got all his work done by Friday was Robinson Crusoe

Bigguy

USA is wrong from what they are saying. It must only be 2 letters I guess.

lesmond

QuoteUSA is wrong from what they are saying. It must only be 2 letters I guess.
Yes I get that, but the way I read it, was that the fix should correct the 3 letters too 2 ie. USA should become US after saving :dontknow

The only person who got all his work done by Friday was Robinson Crusoe

Bigguy

It should yes....as far as I know anyway.

Neša

Jul 15, 2021, 07:48 AM #34 Last Edit: Jul 15, 2021, 08:16 AM by Neša
Do you still get the same error? Has it changed functions? the other one was on array_merge().
I think they have 2 ways to fix this, the 1st is ignore the timezone and log an error for the admin easy to code and quick. The 2nd is to do a map of 3 letter to 2 letter and just convert it by code, they use the 3 letter code as the key and it spits out the 2 letter country  :dontknow

lesmond

Error log


Backtrace information

The only person who got all his work done by Friday was Robinson Crusoe

Neša

Thanks Les, I was able to recreate the bug on my RC4. You are correct for some reason his code is still showing USA it hasn't changed it to US.
I'll see if I can do a work around tomorrow after work, I have an ISO3 to ISO2 map I have limited knowledge on SMF code base I have a small bug to fix. I can post my php file then if you like.

lesmond

Quote from: Neša on Jul 15, 2021, 09:17 AMI can post my php file then if you like.
yes please, I'll give it a shot  :rgton

The only person who got all his work done by Friday was Robinson Crusoe

lesmond

Jul 15, 2021, 07:27 AM #38 Last Edit: Jul 15, 2021, 07:29 AM by lesmond
QuoteThanks Les, I was able to recreate the bug on my RC4. You are correct for some reason his code is still showing USA it hasn't changed it to US.
I'll see if I can do a work around tomorrow after work, I have an ISO3 to ISO2 map I have limited knowledge on SMF code base I have a small bug to fix. I can post my php file then if you like.

I'm really sorry  :emb , it appears I added the GH commits to the wrong test site, tested again on the right test site and it appears they work by changing the inputs from GB,USA to GB,US after saving, no errors  :emb  :emb  :emb

The only person who got all his work done by Friday was Robinson Crusoe

Bigguy

That's good to hear. I posted a quote from Nesa on GH a few minutes ago to see what they say.

lesmond

Quote from: Neša on Jul 14, 2021, 06:28 PMThanks, I've had a look at his fix. It will cause bugs you can't  take the first 2 letters of a 3 letter code. Some countries 2 and 3 letter codes change.
E.G Bangladesh's 2 letter is BD its 3 letter is BGD if you substitute BGD to BG that is Bulgaria.

They might want to look at the 1st and 3rd letter they might match better?

Your right it does that, it takes out the 'D' from 'BGD' leaving 'BG' for Bulgaria.

The only person who got all his work done by Friday was Robinson Crusoe

Bigguy

They have made changes but said it was not an error. refer to the links posted for an explaination from Sesquipidalion. Damn I know I spelt that wrong, lol.

Neša

QuoteI'm really sorry  :emb , it appears I added the GH commits to the wrong test site, tested again on the right test site and it appears they work by changing the inputs from GB,USA to GB,US after saving, no errors  :emb  :emb  :emb

That is interesting I've updated his code as well, I still get the error. I might wait for them to update and re-download  :dontknow

QuoteThat's good to hear. I posted a quote from Nesa on GH a few minutes ago to see what they say.

Yes I have read the reply, I understand what the code did  ;D
I just don't find it a fix for the bug. The best fix would be as he said and I did a while ago, log it to the admin for review.
I might make a mod if I have time to fix it properly and add in the mapping so an admin can mix 3 and 2 letter ISO  :lb

Bigguy

Jul 15, 2021, 06:06 PM #43 Last Edit: Jul 15, 2021, 10:42 PM by Bigguy Reason: spelling
A fix would be cool. I knew you understood it. I'm just tryin to be a middle man here, lol. :emb

Neša

Jul 15, 2021, 10:08 PM #44 Last Edit: Jul 15, 2021, 10:42 PM by Bigguy
Quote from: Bigguy on Jul 15, 2021, 06:06 PMA fix would be cool. I knew you understood it. I'm just tryin to be a middle man here, lol. :emb

Sorry that was a comment for the Dev not you.