couple of errors appeared

Started by lesmond, Jul 14, 2021, 05:29 AM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

lesmond

Jul 14, 2021, 12:48 PM #15 Last Edit: Jul 14, 2021, 05:00 PM by lesmond
just tested on a fresh SMF RC4 and putting the country codes in gives the same errors.


The only person who got all his work done by Friday was Robinson Crusoe

Bigguy

I'm gonna go ahead and say this is a bug.

lesmond

Quoteplus a token verification failure when trying to take them out and save the page. .
I didn't get the that error.

I also get the error when visiting 'Features and Options > General' if the country are input.

The only person who got all his work done by Friday was Robinson Crusoe

lesmond

Quote from: Bigguy on Jul 14, 2021, 12:51 PMI'm gonna go ahead and say this is a bug.
Ok BG thanks, I'm not good at reporting bugs at GH  :emb

The only person who got all his work done by Friday was Robinson Crusoe

Bigguy

Report it at SMF and first see what they say.

Bigguy


lesmond


The only person who got all his work done by Friday was Robinson Crusoe

Bigguy


Bigguy


lesmond

The post has been answered by Sesquipedalian, So if you enter US,GB instead of USA,GB the errors are stopped  :rgton

Quote from: SesquipedalianThis is being tracked at https://github.com/SimpleMachines/SMF2.1/issues/6844.

The problem is that "USA" is not a valid two character ISO country code, and SMF currently doesn't check whether the country codes supplied by the admin are valid before it tries to feed them to the [tt]timezone_identifiers_list()[/tt] function. This will be addressed by adding some validation checks on the country codes.

In the meantime, you can avoid this on your forum by using valid two character ISO country codes. The help text for the "Show time zones from these countries first" setting includes a link that will help you look up the correct country codes for the countries you are interested in.

The only person who got all his work done by Friday was Robinson Crusoe

Bigguy

Seen the post and nice to hear. :chrs

Neša

They should check to see if the codes are ISO 3166-1 alpha-2. You are mixing ISO 3166-1 alpha-2 and ISO 3166-1 alpha-3

Bigguy


Neša

Jul 14, 2021, 06:28 PM #28 Last Edit: Jul 14, 2021, 06:34 PM by Neša
Thanks, I've had a look at his fix. It will cause bugs you can't  take the first 2 letters of a 3 letter code. Some countries 2 and 3 letter codes change.
E.G Bangladesh's 2 letter is BD its 3 letter is BGD if you substitute BGD to BG that is Bulgaria.

They might want to look at the 1st and 3rd letter they might match better?

Bigguy

Maybe we should direct someone to this topic so they can see your idea.